fix: bundesbank url doesn't work with http anymore, updated to https#2
Open
XPanniX wants to merge 1 commit intobav-php:masterfrom
Open
fix: bundesbank url doesn't work with http anymore, updated to https#2XPanniX wants to merge 1 commit intobav-php:masterfrom
XPanniX wants to merge 1 commit intobav-php:masterfrom
Conversation
asdfklgash
pushed a commit
to asdfklgash/bav
that referenced
this pull request
Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When auto-updating the bundesbank file an error was thrown:
PHP Fatal error: Uncaught malkusch\\bav\\DataBackendIOException: Failed to download 'http://www.bundesbank.de/Redaktion/DE/Standardartikel/Aufgaben/Unbarer_Zahlungsverkehr/bankleitzahlen_download.html'. in /var/www/iban-test/vendor/malkusch/bav/classes/dataBackend/file/download/Downloader.php:73\nStack trace:\n#0 /var/www/iban-test/vendor/malkusch/bav/classes/dataBackend/file/FileDataBackend.php(162): malkusch\\bav\\Downloader->downloadContent('http://www.bund...')\n#1 /var/www/iban-test/vendor/malkusch/bav/classes/dataBackend/update/AutomaticUpdatePlan.php(49): malkusch\\bav\\FileDataBackend->update()\n#2 [internal function]: malkusch\\bav\\AutomaticUpdatePlan->malkusch\\bav\\{closure}()\n#3 /var/www/iban-test/vendor/malkusch/bav/classes/util/Lock.php(88): call_user_func(Object(Closure))\n#4 /var/www/iban-test/vendor/malkusch/bav/classes/dataBackend/update/AutomaticUpdatePlan.php(54): malkusch\\bav\\Lock->nonblockingExecuteOnce(Object(Closure))\n#5 /var/www/iban-test/vendor/malkusch/bav/classes/dataBackend/DataBackendContainer.php(72): malkusc in /var/www/iban-test/vendor/malkusch/bav/classes/dataBackend/file/download/Downloader.php on line 73The (old) http://-URL of the bundesbank redirects to https:// which cURL somehow didn't follow when downloading the bankleitzahlen-file. In order to fix that I changed the bundesbank's URL to https://.