This repository was archived by the owner on Jun 29, 2024. It is now read-only.
display no documents and loading message#109
Open
Hyeongee wants to merge 1 commit intobauerj:masterfrom
Open
Conversation
bauerj
suggested changes
Dec 12, 2022
Owner
bauerj
left a comment
bauerj
left a comment
There was a problem hiding this comment.
Thanks a lot for your pull requests!
I have some remarks, could you take a look at it?
| return Container( | ||
| height : 100, | ||
| margin : EdgeInsets.symmetric(horizontal : 100, vertical : 100), | ||
| child : Column( |
Owner
There was a problem hiding this comment.
I think a CircularProgressIndicator would look better instead of the text.
Owner
There was a problem hiding this comment.
Also, this may be shown if the request fails. Can you change this so it only shows when requesting == true?
| style : TextStyle(fontSize : 15), | ||
| textAlign : TextAlign.center,), | ||
|
|
||
| Text(('$searchString').i18n, |
Owner
There was a problem hiding this comment.
Please remove the .i18n, we don't want to translate the search string 🙂
| margin : EdgeInsets.symmetric(horizontal : 100, vertical : 100), | ||
| child : Column( | ||
| children:[ | ||
| Text("There are no documents \n containing".i18n, |
Owner
There was a problem hiding this comment.
Any reason why you didn't want to use Heading instead of Text? Are there visual issues?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fix #108 (comment).
(add no document message and loading message)