refactor(FilterModal): Improve item fetching and handling#78
Draft
refactor(FilterModal): Improve item fetching and handling#78
Conversation
❌ 1 blocking issue (1 total)
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
bastilian
force-pushed
the
filter_modal_improvements_09082025
branch
from
23aba03 to
064b9d0
Compare
Comment on lines
+3
to
+8
| /** | ||
| * This hook is used to cache items that have been requested to show in the FilterModal | ||
| * This is needed in order to retain information to render the filters chip and be able to remove it. | ||
| * | ||
| * Ideally we would not need to do this and a filters value can stand on it's own. | ||
| * |
There was a problem hiding this comment.
Missing JSDoc @returns declaration. [eslint:jsdoc/require-returns]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.