Skip to content

fix(useBulkSelect): Respect itemId on page selection#115

Merged
bastilian merged 1 commit intomainfrom
respect-itemId-on-page-selection
Nov 18, 2025
Merged

fix(useBulkSelect): Respect itemId on page selection#115
bastilian merged 1 commit intomainfrom
respect-itemId-on-page-selection

Conversation

@LightOfHeaven1994
Copy link
Collaborator

@LightOfHeaven1994 LightOfHeaven1994 commented Nov 18, 2025

Unifies behaviour when itemId is used for bulk select. Currently 1by1 item selection will work but selection page will not if id and itemId are not matching. So we need to unify behaviour for page selection too and use itemId if no identifier provided

Story point added shows the issue if old implementation is returned

@qltysh
Copy link

qltysh bot commented Nov 18, 2025

Diff Coverage: The code coverage on the diff in this pull request is 100.0%.

Total Coverage: This PR will increase coverage by 0.02%.

File Coverage Changes
Path File Coverage Δ Indirect
src/hooks/useTableTools/useTableTools.js 0.5
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Owner

@bastilian bastilian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @LightOfHeaven1994!

@bastilian bastilian merged commit 98e4b47 into main Nov 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants