Skip to content

feat(useQueryWithUtilities): Allow passing custom func to combine params#112

Merged
bastilian merged 1 commit intomainfrom
allow-combine-params-use-query
Sep 30, 2025
Merged

feat(useQueryWithUtilities): Allow passing custom func to combine params#112
bastilian merged 1 commit intomainfrom
allow-combine-params-use-query

Conversation

@LightOfHeaven1994
Copy link
Collaborator

Allow passing custom function that will take care of combining filters coming from table state and custom filters (like default one)

Closes #110

@qltysh
Copy link

qltysh bot commented Sep 30, 2025

All good ✅

@LightOfHeaven1994 LightOfHeaven1994 force-pushed the allow-combine-params-use-query branch 2 times, most recently from 10f9998 to cb64f03 Compare September 30, 2025 08:23
@qltysh
Copy link

qltysh bot commented Sep 30, 2025

Diff Coverage: The code coverage on the diff in this pull request is 0.0%.

Total Coverage: This PR will decrease coverage by 0.24%.

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@bastilian
Copy link
Owner

Thank you for this @LightOfHeaven1994!

We just need one more thing for this. We also want to utilise the function in the queryFn function[0]. This is for when the function are called directly.

[0] https://github.com/bastilian/tabletools/blob/main/src/utilities/hooks/useQueryWithUtilities/useQueryWithUtilities.js#L35

@LightOfHeaven1994 LightOfHeaven1994 force-pushed the allow-combine-params-use-query branch from cb64f03 to 2673471 Compare September 30, 2025 09:16
@LightOfHeaven1994
Copy link
Collaborator Author

Thank you for this @LightOfHeaven1994!

We just need one more thing for this. We also want to utilise the function in the queryFn function[0]. This is for when the function are called directly.

[0] https://github.com/bastilian/tabletools/blob/main/src/utilities/hooks/useQueryWithUtilities/useQueryWithUtilities.js#L35

Done 👍

Copy link
Owner

@bastilian bastilian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thank you @LightOfHeaven1994!

@bastilian bastilian merged commit 7dc6a10 into main Sep 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow providing a custom function to combine parameters properly

2 participants