Conversation
hazen
reviewed
Jan 11, 2017
| @@ -0,0 +1,401 @@ | |||
| %% ------------------------------------------------------------------- | |||
| %% | |||
| %% Copyright (c) 2013 Basho Technologies, Inc. | |||
| %% | ||
| %% ------------------------------------------------------------------- | ||
| %% @doc Verification of Active Anti Entropy. | ||
| %% The basic guarantee of AAE is this: Even without the read repairs that will |
There was a problem hiding this comment.
Maybe update the text a bit to mention that this is for time series
|
@korry8911 Can you close this PR and submit a new one on |
hazen
reviewed
Jan 18, 2017
| end, PlCounts, Pl). | ||
|
|
||
| test_data_ts(Start, End) -> | ||
| StepSize = 1000*60*5, |
There was a problem hiding this comment.
How about a comment about what this StepSize is and why we have it?
hazen
reviewed
Jan 18, 2017
| write_data_ts(Node, KVs, Table, _Opts) -> | ||
| [begin | ||
| O = | ||
| case ts_ops:get([Node], Table, key_ts(TS_Data_Tuple)) of |
There was a problem hiding this comment.
Why are we reading the data first? In the verify_aae case they read in case the data already exists and update it instead. In TS, it is write-once and we never update values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@javajolt passes for me locally