Fixed UI freeze occurring when the queue finishes playback.#176
Merged
basharovV merged 2 commits intobasharovV:mainfrom Dec 13, 2025
Merged
Fixed UI freeze occurring when the queue finishes playback.#176basharovV merged 2 commits intobasharovV:mainfrom
basharovV merged 2 commits intobasharovV:mainfrom
Conversation
…ttributes In the Waveform component, optional chaining and default values have been added to multiple accesses of $current.songand its fileInfoproperties to prevent runtime errors when song information hasn't loaded yet or is missing. Additionally, the no-longer-used responsiveproperty has been removed, and the zoom method's invocation parameters have been corrected to comply with the latest API requirements.
Ignoring waveform functions (click, peaks listener) when current song is null, and explicitly clearing waveform when reaching end of queue
Owner
|
Nice thanks! I added a more explicit |
Contributor
Author
Nice, This works on my device as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described, it is unclear whether this issue occurs on your device. On my device, it can be reproduced 100% of the time with the following steps:
There are also related many warnings in DevTools, for example:
Solution: After consulting with AI, I was advised to add optional chaining (
?.) and fallback default values (|| 0or|| 1) for$current.song.fileInfoFollowing these modifications, UI freezing no longer occurs in my tests. It is unclear if there are additional locations that could cause the same issue.