Skip to content

improve: ui#121

Merged
basharovV merged 20 commits intobasharovV:mainfrom
daiyam:improve-ui
Feb 19, 2025
Merged

improve: ui#121
basharovV merged 20 commits intobasharovV:mainfrom
daiyam:improve-ui

Conversation

@daiyam
Copy link
Contributor

@daiyam daiyam commented Jan 24, 2025

This objective of this PR is to improve the UI at different resolution following the discussion at #114 (comment)

Changes on the sidebar are:

  • save if it's opened or not, restore position at start
  • on hover, the expand button is zoomed in to make it bigger and easier to press
  • when not tall enough, the top player is used instead of the player in the sidebar
  • when the window is not wide enough, the sidebar become floating

Changes on the album view are:

  • smaller header with the use of icons
  • if not wide enough, the options are placed in a menu
  • tweak when there is only 0 or 1 column

Tell me if I'm the good direction.

Also I was wonder if some views can be disabled if the screen is too small ("Artist's toolkit").

@basharovV
Copy link
Owner

Some good opinionated choices about what to show when, I think that's good and necessary in an app like this.

when the window is not wide enough, the sidebar become floating

Although it's unlikely that the sidebar will be used much at this window size anyway, I see what you're trying to do here. So we can have both the bottom horizontal player and the sidebar visible at the same time.
However it seems that it stays floating as you resize up, and then you can end up in this situation where there is no player:
image

smaller header with the use of icons

I like the icons, there's an issue where resizing down to the queue - the settings icon is still there.

@daiyam
Copy link
Contributor Author

daiyam commented Jan 29, 2025

However it seems that it stays floating as you resize up, and then you can end up in this situation where there is no player:

Yes, I had also some issues but I wanted to have your feedback before hunting then down ;)

Ah! I should have put some screenshot of the different resolutions I've tested...

@basharovV basharovV added this to the 0.13.0 milestone Jan 29, 2025
@daiyam
Copy link
Contributor Author

daiyam commented Jan 29, 2025

However it seems that it stays floating as you resize up, and then you can end up in this situation where there is no player:

I found the issue. In your screenshot, the sidebar is in floating mode and the window has been resize up so that the sidebar becomes fixed and hides the bottom player. I need to force a redraw of the sidebar.

@daiyam
Copy link
Contributor Author

daiyam commented Jan 29, 2025

if not wide enough, the options are placed in a menu

Doesn't seem to work anymore...

Edit: Oh! It's the sidebar which isn't floating anymore...

@daiyam
Copy link
Contributor Author

daiyam commented Jan 29, 2025

@basharovV The PR should be ok, now.

Tell me if I did miss something or you want me to make changes.

There is still some comments to remove (in the css in sidebar, regarding window size).

@daiyam
Copy link
Contributor Author

daiyam commented Feb 6, 2025

There is still some comments to remove (in the css in sidebar, regarding window size).

I will remove them when no changes are needed.

@basharovV
Copy link
Owner

@daiyam The only thing that looks broken is the WINDOW_CONTROLS_WIDTH doesn't seem to be applied when resizing down until the sidebar is hidden, so the (macOS) window controls are overlapping:
image

@daiyam
Copy link
Contributor Author

daiyam commented Feb 8, 2025

@daiyam The only thing that looks broken is the WINDOW_CONTROLS_WIDTH doesn't seem to be applied when resizing down until the sidebar is hidden, so the (macOS) window controls are overlapping:

Fixed

@basharovV
Copy link
Owner

@daiyam I think this is fine to merge, I played around with it some more. Can always adjust things later :) I like that the wiki hides as well.

@basharovV basharovV merged commit 274eb99 into basharovV:main Feb 19, 2025
4 checks passed
@daiyam daiyam deleted the improve-ui branch February 19, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants