-
Notifications
You must be signed in to change notification settings - Fork 2
merge: feature/libobjfmt (now called libbinfmt internall) #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jeffpanici75
wants to merge
353
commits into
develop
Choose a base branch
from
feature/libobjfmt
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* turns out the clip rect for a window once inside a Begin excludes the title bar. this makes sense, the clip rect is the "client are" of the window. * unfortunately, when a window is docked, we need to draw the texture on its tab and when undocked, we have to place it on the classic title bar in a slightly different location. * still messy, but improving.
...i mean, it works, but it isn't as solid as i'd like. gonna think on it for a while and see if i can come up with any better ideas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a placeholder pull request. I'll be updating this with a TODO list of outstanding items before the merge can be completed.