feat: Add back navigation support when launching with startScreen #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Kick is launched directly to a specific module using startScreen parameter, pressing back at the root level now properly closes the Kick window instead of doing nothing. Changes: - Add onCloseRequested callback to RootComponent interface - Create CloseAwareStackNavigation wrapper to intercept pop() at root level - Set up close handler in RootContent via LaunchedEffect - Add BackHandler support in ControlPanelContent for system back button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When Kick is launched directly to a specific module using the
startScreenparameter, pressing back at the root level now properly closes the Kick window instead of doing nothing.Problem
When using
Kick.launch(context, startScreen)to open a specific module directly (e.g., Control Panel), pressing the back button at the root level did nothing because Decompose's stack navigation doesn't allow the stack to become empty.Solution
onCloseRequestedcallback toRootComponentinterfaceCloseAwareStackNavigationwrapper that interceptspop()calls at root levelLaunchedEffectinRootContentBackHandlersupport inControlPanelContentfor system back buttonTesting
Tested on both Android and iOS - back navigation now correctly closes Kick when launched with startScreen.