refactor: remove enabled field from fugitive/neogit config#126
Merged
barrettruth merged 1 commit intomainfrom Feb 16, 2026
Merged
refactor: remove enabled field from fugitive/neogit config#126barrettruth merged 1 commit intomainfrom
barrettruth merged 1 commit intomainfrom
Conversation
barrettruth
force-pushed
the
refactor/implicit-integration-enabled
branch
from
264c8d8 to
3be4a47
Compare
Problem: users had to pass `enabled = true` or `enabled = false` inside
fugitive/neogit config tables, which was redundant — table presence
already implied the integration should be active.
Solution: remove the `enabled` field from the public API. Table presence
now implies enabled, `false` disables. `true` expands to sub-defaults.
The `enabled` field is still accepted for backward compatibility:
`{ enabled = false }` collapses to `false`, and `enabled = true` or nil
strips the field silently. Default config changed from
`{ enabled = false, ... }` tables to just `false`. Added 20
compute_filetypes tests covering all config shapes. Updated docs.
barrettruth
force-pushed
the
refactor/implicit-integration-enabled
branch
from
3be4a47 to
bd7a44a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users had to pass
enabled = trueorenabled = falseinsidefugitive/neogit config tables, which was redundant — table presence
already implied the integration should be active.
Solution
Remove the
enabledfield from the public API. Table presence nowimplies enabled,
falsedisables,trueexpands to sub-defaults.The
enabledfield is still accepted for backward compatibility.Added 20
compute_filetypestests covering all config shapes (true,false, table, nil, backward-compat enabled field). Updated docs
and type annotations.