Skip to content

fix: viewInsets should not be updated on keyboard open/close #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
P0labrD merged 2 commits into from
Oct 10, 2025
Merged

fix: viewInsets should not be updated on keyboard open/close #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5490a58
fix: viewPadding should not change on keyboard opening
Oct 8, 2025
a7e13c5
chore: update version and changelog
Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.10.1

* fix: revert viewPadding update when keyboard opens/closes.

## 0.10.0

* feat: Add support for 2-button and 3-button navigation for Android devices.
Expand Down
2 changes: 0 additions & 2 deletions lib/src/adaptive/window_configuration_tester.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,11 @@ extension WidgetTesterWithConfigurableWindow on WidgetTester {
void configureOpenedKeyboardWindow(WindowConfigData windowConfig) {
view.viewInsets = windowConfig.viewInsets;
view.padding = windowConfig.padding.copyWith(bottom: 0);
view.viewPadding = windowConfig.viewInsets;
}

/// Configure the tester window to represent a closed keyboard on the given device variant.
void configureClosedKeyboardWindow(WindowConfigData windowConfig) {
view.resetViewInsets();
view.padding = windowConfig.padding;
view.viewPadding = windowConfig.padding;
}
}
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: adaptive_test
description: >-
A Flutter package to generate adaptive golden files during widget tests.
version: 0.10.0
version: 0.10.1
homepage: https://github.com/bamlab/adaptive_test
repository: https://github.com/bamlab/adaptive_test

Expand Down
Loading