reference/wifi-dongles.md: Remove list of supported modems#3128
Merged
flowzone-app[bot] merged 2 commits intomasterfrom Jan 14, 2025
Merged
reference/wifi-dongles.md: Remove list of supported modems#3128flowzone-app[bot] merged 2 commits intomasterfrom
flowzone-app[bot] merged 2 commits intomasterfrom
Conversation
The list of supported wifi dongles and modems is out of date and sets an uneralistic expectation for hardware compatibility - its better to remove this until we actually have a proper modem story Change-type: patch Signed-off-by: Ryan Cooke <ryan@balena.io>
rcooke-warwick
requested review from
aethernet,
alexgg,
rmorillo24,
shaunmulligan and
vipulgupta2048
Contributor
|
Website deployed to CF Pages, 👀 preview link https://363a559f.balenacloud-docs.pages.dev |
Contributor
There was a problem hiding this comment.
From my side it's a +1 to merge, trying not to trigger the auto-merge.
@rcooke-warwick can you also comment the following files being pulled from the OS document. We should do a follow up PR to remove this information from the OS docs as well.
- Comment line 37 to 42
Lines 37 to 42 in 024ed5b
Contributor
Author
|
thanks @vipulgupta2048 - do you mean I should comment out/delete what you've highlighted ? |
Contributor
|
@rcooke-warwick Comment out the lines highlighted, we can remove them once the other PR merges in the OS readme and the information no longer exists. |
Change-type: patch Signed-off-by: Ryan Cooke <ryan@balena.io>
vipulgupta2048
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The list of supported wifi dongles and modems is out of date and sets an uneralistic expectation for hardware compatibility - its better to remove this until we actually have a proper modem story
Change-type: patch
Supersedes #2193 if we go with this