add protobuffers version to proto file #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it makes sense to add the protobuffers version tag to the .proto spec as it can help end users who might want to use it to decode raw protobuf messages when debugging their apps which need to talk to the pinba2 engine - at least it would have saved me the time I wasted digging into all the differences between protobuffers versions ;-)
The tag added makes it mandatory to use, afaict, protoc compiler 3.0 or later to parse the file. That was released in 2016 and is the default in all currently supported lts releases of Debian and Ubuntu, so there is little chance of users still relying on older versions.