Merged
Conversation
📝 WalkthroughWalkthroughThe git clone flag in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @internal/git/Git.go:
- Line 39: The test in internal/git/default_test.go expects the old
"--recursive" flag but the implementation in internal/git/Git.go now uses
"--no-checkout"; update the test's validCmdLine (the validCmdLine variable in
default_test.go) to replace "--recursive" with "--no-checkout" so the expected
command matches the new clone behavior used by the build flow (clone without
checkout → explicit checkout → submodule update).
mikusaq
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have two branches BRANCH_A and BRANCH_MODULES, where BRANCH_A does not contain git submodules, and BRANCH_MODULES has several private/unaccessible submodules for the user who tries to access them.
Let BRANCH_MODULES be set up as the default git branch. Then Packager fails with "Cannot access" because it clones whole repository by the standard
git clone, which checks out to the default branch (BRANCH_MODULES) and then to a BRANCH_AI suggest adding option
--no-checkoutt ogit clone.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.