build(dockerfile): use BuildKit secret for MASTER_PASSWORD#219
Closed
b23prodtm wants to merge 1 commit intofix/composefrom
Closed
build(dockerfile): use BuildKit secret for MASTER_PASSWORD#219b23prodtm wants to merge 1 commit intofix/composefrom
b23prodtm wants to merge 1 commit intofix/composefrom
Conversation
### What changed
- Use Docker BuildKit secret mount for `master_password` in `Dockerfile.x86_64`.
- Read secret from `/run/secrets/master_password` into `MASTER_PASSWORD` during `RUN`.
- Pass `-p` to `./configure.sh` only when `MASTER_PASSWORD` is set using `${MASTER_PASSWORD:+-p "$MASTER_PASSWORD"}`.
- Keep database migration steps unchanged.
### Why
- Prevents leaking credentials into image layers, env, or build args.
- Allows builds to proceed without a password by omitting the `-p` flag when unset.
### Build notes
- Requires BuildKit: set `DOCKER_BUILDKIT=1`.
- Provide the secret at build time, e.g.:
`docker build --secret id=master_password,src=./master_password.txt .`
Owner
Author
|
Added in #216 secrets |
b23prodtm
deleted the
chunk/buildkit-secret-master-password-1771185716586
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.