Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

πŸ’‘ What: Refactored ArrestReportForm, AdvancedArrestReportForm, and GeneralSection to use Zustand selectors instead of full-store subscriptions.
🎯 Why: Subscribing to the entire settings-store caused these heavy components to re-render whenever any setting changed (e.g. toggling hidden factions), leading to performance issues.
πŸ“Š Impact: Eliminates unnecessary re-renders of these forms when unrelated settings change.
πŸ”¬ Measurement: Verified with npm run typecheck and npm run lint to ensure no regressions.


PR created automatically by Jules for task 7803113398323548519 started by @booskit-codes

- Refactored `ArrestReportForm` to use selector for `experimentalFeatures`.
- Refactored `AdvancedArrestReportForm` to use selectors for callsign settings.
- Refactored `GeneralSection` to use selector for `predefinedCallsigns` and removed unused `defaultCallsignId`.
- Prevents unnecessary re-renders when unrelated settings change.
@google-labs-jules
Copy link
Contributor Author

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants