Log verbosity, pid parametrised and pipe writing only on when sound is detected#19
Open
ale275 wants to merge 26 commits intob-fitzpatrick:masterfrom
Open
Log verbosity, pid parametrised and pipe writing only on when sound is detected#19ale275 wants to merge 26 commits intob-fitzpatrick:masterfrom
ale275 wants to merge 26 commits intob-fitzpatrick:masterfrom
Conversation
- refactored val variable to samplerate - made buffer and capture sizes calculation function of samplerate and captured channels count
- cleaned up help message in case of error
- made out pipe size twice the capture buffer size - added error message when pipe resizing fails - added warning when pipe size different from the requested one
…el count - variable name for sample rate is CPIPED_SR - variable name for sample size is CPIPED_SS - variable name for channel count is CPIPED_CC - those can be used by the called script to perform format conversion or other arithmetic if needed
Owner
|
@ale275 looks like a lot of good work. I haven't used this in years and don't have anything set up to test it. Would you be interested in taking over this repo? |
Author
|
thank you @b-fitzpatrick. I have some more development for the cpiped ecosystem to develop so I am more than happy to support if you want |
Owner
|
I looked into transferring the repo and decided against it. I'm thinking that I'll add a message pointing to the pull requests and archive the repo. |
Author
|
Sure no problem I will also rewrite the readme in the coming days to reference work done thank you so much in the first place for this |
ale275
force-pushed
the
master
branch
3 times, most recently
from
ec3f8e4 to
155b59e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull requests to incorporate different changes by different users