Unfinished new parser implementation (Sourcery refactored)

[sourcery-ai]

Pull Request #36 refactored by Sourcery.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.

To incorporate these changes, you can either:

1. Merge this Pull Request instead of the original, or

2. Ask your contributor to locally incorporate these commits and push them to
   the original Pull Request

   Incorporate changes via command line

   git fetch https://github.com/b-Development-Team/b-star pull/36/head
   git merge --ff-only FETCH_HEAD
   git push

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Help us improve this pull request!

[sourcery-ai]

Function findFunction refactored with the following changes:

• Inline variable that is immediately returned (inline-immediately-returned-variable)

This removes the following comments ( why? ):

# if functionWanted is None:
#     functionWanted = Commands.src.interpreter.tempFunctionsFile.functions.get(name)
# This tries to find a user-made function first, then tries the built-in ones.

[sourcery-ai]

Function isUniqueValue refactored with the following changes:

• Simplify boolean if expression (boolean-if-exp-identity)
• Remove unnecessary casts to int, str, float or bool (remove-unnecessary-cast)

[sourcery-ai]

Function runCodeSandbox refactored with the following changes:

• Remove unnecessary calls to enumerate when the index is not used (remove-unused-enumerate)

[sourcery-ai]

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics	Before	After	Change
Complexity	4.57 ⭐	4.60 ⭐	0.03 👎
Method Length	74.93 🙂	74.21 🙂	-0.72 👍
Working memory	10.18 😞	10.19 😞	0.01 👎
Quality	69.17% 🙂	69.17% 🙂	0.00%

Other metrics	Before	After	Change
Lines	240	235	-5

Changed files	Quality Before	Quality After	Quality Change
Config/b_star_interpreter/expression.py	72.14% 🙂	71.48% 🙂	-0.66% 👎
Config/b_star_interpreter/function.py	72.81% 🙂	73.16% 🙂	0.35% 👍
Config/b_star_interpreter/run.py	63.42% 🙂	63.61% 🙂	0.19% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
Config/b_star_interpreter/run.py	returnError	4 ⭐	186 😞	31 ⛔	39.89% 😞	Try splitting into smaller methods. Extract out complex expressions
Config/b_star_interpreter/function.py	Function.run	5 ⭐	119 🙂	12 😞	57.91% 🙂	Extract out complex expressions
Config/b_star_interpreter/expression.py	Expression	10 🙂	133 😞	8 🙂	59.37% 🙂	Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!