Getting protobuf up to speed with Elixir 0.13.0. Only one test is breaking#8
Open
lowks wants to merge 1 commit intoazukiapp:masterfrom
Open
Getting protobuf up to speed with Elixir 0.13.0. Only one test is breaking#8lowks wants to merge 1 commit intoazukiapp:masterfrom
lowks wants to merge 1 commit intoazukiapp:masterfrom
Conversation
|
I've been maintaining a fork over at bitwalker/elixir-protobuf. If you submit any PRs, I'll gladly accept. Next on my list is moving from records to structs, but that's going to be a bit involved due to the macro magic. |
Author
|
Okay. I will hop on over there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes taking out mostly deprecated syntax, Only one thing is left broken in the test but this requires changes at deeper level related to Records.