Skip to content

Exclude storages with only NFS File Shares from remediation #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aboli-msft wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Exclude storages with only NFS File Shares from remediation #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd70eb3
Exclude storages with only NFS File Shares from remediation
Aboli-msft Jun 8, 2022
b2c88f8
adding zip folder for updated remediation script
Aboli-msft Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions Scripts/RemediationScripts/Remediate-EnableEncryptionInTransitForStorageAccounts.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,23 @@ function Enable-StorageEncryptionInTransit
$storageAccounts | ForEach-Object {
if ($_.EnableHttpsTrafficOnly)
{
if($_.Kind -eq "FileStorage"){
$fileshares=@()
$fileshares= Get-AzRMStorageShare -StorageAccountName $_.StorageAccountName -ResourceGroupName $_.ResourceGroupName
if(($fileshares|Measure-Object).Count -gt 0)
{
$SMBFileShares = @()
$NFSFileShares = @()
$SMBFileShares = $fileshares|Where-Object{$_.EnabledProtocols -contains "SMB"}
$NFSFileShares = $fileshares|Where-Object{$_.EnabledProtocols -contains "NFS"}
if($NFSFileShares.Count -gt 0 -and $SMBFileShares.Count -eq 0)
{
$storagewithOnlyNFSShares = $_.StorageAccountName
Write-Host "Excluding Storage Accounts $($_.StorageAccountName) with type FileStorage and having only NFS fileshares"
$storageAccounts=$storageAccounts|Where-Object{$_.StorageAccountName -ne $storagewithOnlyNFSShares}
}
}
}
$stgWithEnableHTTPS += $_
}
else
Expand Down Expand Up @@ -609,6 +626,26 @@ function Disable-StorageEncryptionInTransit
$remediatedResourceLog | ForEach-Object {
try
{
$res = Get-AzStorageAccount -ResourceGroupName $_.ResourceGroupName -Name _.StorageAccountName
if($_.Kind -eq "FileStorage"){
$fileshares=@()
$fileshares= Get-AzRMStorageShare -StorageAccountName $_.StorageAccountName -ResourceGroupName $_.ResourceGroupName
if(($fileshares|Measure-Object).Count -gt 0)
{
$SMBFileShares = @()
$NFSFileShares = @()
$SMBFileShares = $fileshares|Where-Object{$_.EnabledProtocols -contains "SMB"}
$NFSFileShares = $fileshares|Where-Object{$_.EnabledProtocols -contains "NFS"}
if($NFSFileShares.Count -gt 0 -and $SMBFileShares.Count -eq 0)
{
$storagewithOnlyNFSShares = $_.StorageAccountName
Write-Host "Excluding Storage Accounts $($_.StorageAccountName) with type FileStorage and having only NFS fileshares"
continue
}
}
}


$output = Set-AzStorageAccount -ResourceGroupName $_.ResourceGroupName -Name $_.StorageAccountName -EnableHttpsTrafficOnly $false -ErrorAction SilentlyContinue
if($output -ne $null)
{
Expand Down
Binary file modified TemplateFiles/RemediationScripts.zip
View file
Open in desktop
Binary file not shown.