Skip to content

Conversation

@Yimura
Copy link
Contributor

@Yimura Yimura commented Aug 22, 2025

Description

This PR changes the behaviour of the underlying checkbox component to not render unless the item is selected.

Fixes #123

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

People previously having relied on their custom checkbox always rendering will be impacted. As the checkbox is unable to know if it's selected or not I wouldn't expect anyone to be negatively impacted by this.

How Has This Been Tested?

Before

before image

After

after image

Test Configuration:

  • Firmware version: Android 15
  • Hardware: OnePlus 11 5G
  • Toolchain: /
  • SDK: 35

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Fixes azeezat#123

Signed-off-by: Andreas Maerten <24669514+Yimura@users.noreply.github.com>
@Yimura Yimura changed the title fix(Checkbox): Selectively show custom checkbox component fix: Selectively show custom checkbox component Aug 22, 2025
@Yimura
Copy link
Contributor Author

Yimura commented Aug 22, 2025

@azeezat, let me know if the new code requires further documentation or commenting.

@Yimura Yimura marked this pull request as ready for review August 22, 2025 18:10
Yimura added a commit to Yimura/RemoteUnlockApp that referenced this pull request Aug 22, 2025
@azeezat
Copy link
Owner

azeezat commented Aug 24, 2025

Thanks @Yimura for this fix!

@azeezat azeezat merged commit d6eeff2 into azeezat:main Aug 24, 2025
4 of 5 checks passed
@azeezat azeezat added bug Something isn't working released labels Aug 24, 2025
@azeezat
Copy link
Owner

azeezat commented Aug 24, 2025

🚀 This pull request is included in v2.1.8. See Release 2.1.8 for release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom checkbox component is still visible regardless of checkbox value.

2 participants