Add multiple URL option, revised email instructions, color text output#4
Open
brianabouchard wants to merge 1 commit intoayoTyler:mainfrom
Open
Add multiple URL option, revised email instructions, color text output#4brianabouchard wants to merge 1 commit intoayoTyler:mainfrom
brianabouchard wants to merge 1 commit intoayoTyler:mainfrom
Conversation
Created a dictionary and modified methods to allow checking of multiple items. Also added clarifying instructions to email option on one way to bypass.
Owner
|
Briana, excellent work with this! I am excited to review this PR when I am home. Great ideas! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, thanks so much for this awesome stock checker!
Created a dictionary and modified methods to allow checking of multiple items continuously. For those of us on the hunt for a GPU and open to multiple models, this could be really helpful!
Added clarifying instructions to email option on one way to bypass that part. Though you can type in anything, it seems nice to specify just hitting return will bypass it. If I have time, I'll try to refactor and submit a PR with an email opt-out prompt later.
Lastly, added color text output to better catch the attention of users in terminal if they aren't using the email option.