#1462 Introduce sns batch template#1574
Merged
MatejNedic merged 5 commits intoawspring:mainfrom Feb 11, 2026
Merged
Conversation
MatejNedic
requested review from
maciejwalkowiak and
tomazfernandes
as code owners
github-actions
bot
added
component: sns
...rc/main/java/io/awspring/cloud/sns/core/batch/executor/SequentialBatchExecutionStrategy.java
Show resolved
Hide resolved
...s/src/main/java/io/awspring/cloud/sns/core/batch/executor/DefaultBatchExecutionStrategy.java
Outdated
Show resolved
Hide resolved
| * @author Matej Nedic | ||
| * @since 4.0.1 | ||
| */ | ||
| public interface SnsBatchOperations { |
Contributor
There was a problem hiding this comment.
Shouldn't this interface be similar to SnsOperations BUT with batch? Meaning, a batch method for sending SnsNotification objects.
Member
Author
There was a problem hiding this comment.
I have introduced sentNotifications method. Regarding other methods there is no point since Headers are different for each message.
I wouldn't for first hand but we can introduce MessagePostProcessor as well in one of method signatures.
spring-cloud-aws-sns/src/main/java/io/awspring/cloud/sns/core/batch/SnsBatchTemplate.java
Show resolved
Hide resolved
...s/src/main/java/io/awspring/cloud/sns/core/batch/executor/DefaultBatchExecutionStrategy.java
Outdated
Show resolved
Hide resolved
spring-cloud-aws-sns/src/main/java/io/awspring/cloud/sns/core/SnsHeaderConverterUtil.java
Outdated
Show resolved
Hide resolved
...src/test/java/io/awspring/cloud/sns/core/batch/converter/DefaultSnsMessageConverterTest.java
Show resolved
Hide resolved
...-aws-sns/src/test/java/io/awspring/cloud/sns/core/batch/SnsBatchTemplateIntegrationTest.java
Outdated
Show resolved
Hide resolved
...-aws-sns/src/test/java/io/awspring/cloud/sns/core/batch/SnsBatchTemplateIntegrationTest.java
Outdated
Show resolved
Hide resolved
...-aws-sns/src/test/java/io/awspring/cloud/sns/core/batch/SnsBatchTemplateIntegrationTest.java
Show resolved
Hide resolved
...ud-aws-sns/src/main/java/io/awspring/cloud/sns/core/batch/converter/SnsMessageConverter.java
Outdated
Show resolved
Hide resolved
spring-cloud-aws-sns/src/main/java/io/awspring/cloud/sns/core/batch/SnsBatchOperations.java
Outdated
Show resolved
Hide resolved
Contributor
maciejwalkowiak
left a comment
maciejwalkowiak
left a comment
There was a problem hiding this comment.
Before merging it, lets create a branch 4.0.x for bugfixes and then merge this one to main.
Member
Author
|
Branch 4.0.x created -> https://github.com/awspring/spring-cloud-aws/tree/4.0.x All PR comments fixed |
maciejwalkowiak
approved these changes
Feb 11, 2026
Contributor
|
Thanks @MatejNedic ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Introduces simple Batching template for Spring Messages abstraction
💡 Motivation and Context
Closes #1462
💚 How did you test it?
📝 Checklist
🔮 Next steps