[breaking] force logit output of focal loss to conform to (N, 2) shape for binary classification #1313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thvasilo
force-pushed
the
focal-out-shape
branch
2 times, most recently
from
81b4a4d to
ffd6bcc
Compare
classicsong
reviewed
Aug 5, 2025
Contributor
classicsong
left a comment
classicsong
left a comment
There was a problem hiding this comment.
The key problem of setting decoder_output_dim=2 is that we change the implementation of the decoder layer. Specifically, it's parameter size will be 2X larger and the parameters are impacted by the [:, 1].
Contributor
Theoretically, the effective parameters of both decoder implementations are identical. The difference is, with the new implementation the output [:, 0] is meaningless. @thvasilo Can you set [:, 0] to all zeros when returning it for inference? |
…e for binary classification
thvasilo
force-pushed
the
focal-out-shape
branch
from
ffd6bcc to
b5019a1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1242
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.