Skip to content

Conversation

@staskh
Copy link

@staskh staskh commented Nov 18, 2024

What does this PR do?

Fix dead loop inside SocaCliContext.aws()

When AWS credentials are received via SSO, the original code is entering an endless loop, resulting in a RecursionError exception.
To replicate error:

aws sso login
invoke admin.test-iam-policies --cluster-name res-demo --aws-region eu-west-1 

How was this PR tested?

Please describe any testing performed.

  • Describe the automated and/or manual tests executed to validate the patch.
  • Describe the added/modified tests.

Manual test:

aws sso login
invoke admin.test-iam-policies --cluster-name res-demo --aws-region eu-west-1 

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title.
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.
  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

License

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.te this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant