Improve Integration Testing Around S3 Upload#198
Open
Cole-Greer wants to merge 2 commits intodevelopfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #190
Description of changes:
This PR contains 2 parts. The first commit updates all of the integration tests to assume IAM auth is enabled on the target Neptune cluster, which reduces barriers to run tests as it allows for use of Neptune public endpoints.
The second part extends the export service integration tests to include validation of the S3 upload. These tests now include an S3 upload to a bucket provided via environment variables, and the tests will pull the files from S3 and validate expected results. This is an extra layer in addition to validating the local files.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.