Skip to content

Add branded types for RDF namespace and prefix identifiers#1538

Merged
kmcginnes merged 1 commit intoaws:mainfrom
kmcginnes:feature/schema/rdf-branded-types
Feb 24, 2026
Merged

Add branded types for RDF namespace and prefix identifiers#1538
kmcginnes merged 1 commit intoaws:mainfrom
kmcginnes:feature/schema/rdf-branded-types

Conversation

@kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Feb 24, 2026

Description

  • Add types.ts with IriNamespace, IriLocalValue, IriParts, RdfPrefix, GeneratedPrefix, and NormalizedIriNamespace branded types
  • Apply branded types to PrefixTypeConfig (prefix and uri fields)
  • Add branded type casts to existing logic and test files
  • Update steering docs with branded type table entries and backward compatibility testing guidance

Validation

  • pnpm check:types passes with no errors
  • pnpm test passes with no failures
  • Existing behavior is unchanged; only type-level safety is added

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

- Add types.ts with IriNamespace, IriLocalValue, IriParts, RdfPrefix,
  GeneratedPrefix, and NormalizedIriNamespace branded types
- Apply branded types to PrefixTypeConfig (prefix, uri fields)
- Add branded type casts to existing code and tests
- Update steering docs with branded type table and backward compat testing guidance
@kmcginnes kmcginnes marked this pull request as ready for review February 24, 2026 00:24
@kmcginnes kmcginnes merged commit a94b1f8 into aws:main Feb 24, 2026
2 checks passed
@kmcginnes kmcginnes deleted the feature/schema/rdf-branded-types branch February 24, 2026 01:13
@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.23%. Comparing base (c5affc5) to head (673240b).
⚠️ Report is 74 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1538       +/-   ##
===========================================
+ Coverage   47.81%   65.23%   +17.42%     
===========================================
  Files         382      355       -27     
  Lines        8525     7930      -595     
  Branches     3159     2901      -258     
===========================================
+ Hits         4076     5173     +1097     
+ Misses       3070     1990     -1080     
+ Partials     1379      767      -612     
Flag Coverage Δ
unittests 65.23% <100.00%> (+17.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants