fix(security): update fast-xml-parser to 5.3.5+ for CVE-2026-25896#1534
fix(security): update fast-xml-parser to 5.3.5+ for CVE-2026-25896#1534
Conversation
|
@abhu85 thank you for the submission. I had a PR that was just merged that should fix this. If it is not fixed by my PR, then I'll look in to merging this one. |
|
@kmcginnes Thank you for the quick response! I checked your merged PR #1531 and the current The current override: "fast-xml-parser@<5.3.4": ">=5.3.4"Should be: "fast-xml-parser@<5.3.5": ">=5.3.5"My PR updates this override to ensure versions below 5.3.5 are upgraded. If you'd prefer to handle this yourself or a different way, happy to close this PR. Let me know how you'd like to proceed! |
Update the pnpm override for fast-xml-parser from >=5.3.4 to >=5.3.5 to address CVE-2026-25896 (GHSA-m7jm-9gc2-mpf2). The vulnerability allows entity encoding bypass via regex injection in DOCTYPE entity names. An attacker can shadow built-in XML entities (e.g., < >) with arbitrary values, potentially leading to XSS when parsed output is rendered. Affected versions: >= 4.1.3 and < 5.3.5 Fixed in: 5.3.5+ Current lock file version: 5.3.7 Closes aws#1532 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
337d510 to
cdc51a4
Compare
|
Rebased onto Changes in this rebase:
The lockfile now inherits from upstream - pnpm will apply the updated fast-xml-parser override at resolve time during CI. Ready for review. 🙏 |
kmcginnes
left a comment
There was a problem hiding this comment.
You're right. We should take your PR for the updated override. Good call.
The package.json file looks great. However, the pnpm-lock.yaml seems to be a bit mangled from all the rebasing/merging. It might need another pass or a regen.
Summary
Update the pnpm override for
fast-xml-parserfrom>=5.3.4to>=5.3.5to address CVE-2026-25896 (GHSA-m7jm-9gc2-mpf2).Problem
The fast-xml-parser library versions
>= 4.1.3and< 5.3.5are affected by a critical vulnerability that allows entity encoding bypass via regex injection in DOCTYPE entity names. An attacker can shadow built-in XML entities (e.g.,<,>) with arbitrary values, potentially leading to XSS when parsed output is rendered.The previous override targeted
>=5.3.4, but the CVE was fixed in version 5.3.5.Fix
fast-xml-parser@<5.3.5->>=5.3.5Changes
package.json: Updated override constraintpnpm-lock.yaml: Updated to fast-xml-parser 5.3.7Test Plan
pnpm installCloses #1532
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com