Skip to content

Conversation

@feiyangliu2023
Copy link
Contributor

Issue

D356975867

Enhanced the release workflow to support dual versioning by introducing a separate SageMaker Code Editor version alongside the Code Editor version. This allows independent version tracking for SageMaker-specific releases.

Description of Changes

Removed automatic tag-based triggers, now exclusively using workflow_dispatch with input of code-editor version and sagemaker-code-editor version

Added sagemakerCodeEditorVersion field alongside existing codeEditorVersion in product.json in compiled file

Testing

Tested locally by:
Creating tag 1.0.2 on branch 1.0
Running workflow with both version inputs: https://github.com/feiyangliu2023/code-editorv2/actions/runs/20097218364
Check artifact uploaded in local release: https://github.com/feiyangliu2023/code-editorv2/releases/tag/1.0.2
Extracting tarballs and verifying both version fields appear correctly in product.json


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@feiyangliu2023 feiyangliu2023 requested a review from a team as a code owner December 10, 2025 11:56
@vpaiu
Copy link
Contributor

vpaiu commented Dec 10, 2025

  • So currently in your approach you fetch the artifacts from the latest commit_sha of the branch which you call the workflow from, but we want to fetch the artifacts for the commit_sha on which the tag was created on.

  • Also do we wish to have the tag creation step as manual?

  • And we need to restrict who can dispatch the workflow, we can discuss this internally.

  • I see that the PR is for the main branch, we will need to also merge it to the 1.0 branch.

@feiyangliu2023 feiyangliu2023 changed the base branch from main to 1.0 December 10, 2025 14:46
@feiyangliu2023 feiyangliu2023 changed the base branch from 1.0 to main December 10, 2025 14:48
@feiyangliu2023 feiyangliu2023 requested a review from a team as a code owner December 10, 2025 14:57
@feiyangliu2023 feiyangliu2023 changed the base branch from main to 1.0 December 10, 2025 14:58
@feiyangliu2023
Copy link
Contributor Author

  • So currently in your approach you fetch the artifacts from the latest commit_sha of the branch which you call the workflow from, but we want to fetch the artifacts for the commit_sha on which the tag was created on.
  • Also do we wish to have the tag creation step as manual?
  • And we need to restrict who can dispatch the workflow, we can discuss this internally.
  • I see that the PR is for the main branch, we will need to also merge it to the 1.0 branch.

Yes, not commit_sha is fetched from where tag is created.
I would suggest keep the tag creation as manual so it is traceable and prevent errors when tags automatically created on wrong commit.
We can discuss this later today.
Yes merged to 1.0

Comment on lines +1 to +4
Index: code-editorv2/code-editor-src/src/vs/workbench/browser/parts/dialogs/dialogHandler.ts
===================================================================
--- code-editorv2.orig/code-editor-src/src/vs/workbench/browser/parts/dialogs/dialogHandler.ts
+++ code-editorv2/code-editor-src/src/vs/workbench/browser/parts/dialogs/dialogHandler.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paths are a bit weird here, I see that your folder name appears here - code-editorv2. For example this is how it looks in other patches:

Index: code-editor-src/build/npm/dirs.js
===================================================================
--- code-editor-src.orig/build/npm/dirs.js
+++ code-editor-src/build/npm/dirs.js

Comment on lines +15 to +18
Index: code-editorv2/code-editor-src/src/vs/base/common/product.ts
===================================================================
--- code-editorv2.orig/code-editor-src/src/vs/base/common/product.ts
+++ code-editorv2/code-editor-src/src/vs/base/common/product.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue here

@feiyangliu2023 feiyangliu2023 deleted the map-versioning branch December 11, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants