-
Notifications
You must be signed in to change notification settings - Fork 17
Add SageMaker Code Editor version mapping to release workflow #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cb0fa92 to
806a58d
Compare
…n product.json metadata
Yes, not commit_sha is fetched from where tag is created. |
806a58d to
5f946ce
Compare
cbf054f to
2f6a2dd
Compare
| Index: code-editorv2/code-editor-src/src/vs/workbench/browser/parts/dialogs/dialogHandler.ts | ||
| =================================================================== | ||
| --- code-editorv2.orig/code-editor-src/src/vs/workbench/browser/parts/dialogs/dialogHandler.ts | ||
| +++ code-editorv2/code-editor-src/src/vs/workbench/browser/parts/dialogs/dialogHandler.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The paths are a bit weird here, I see that your folder name appears here - code-editorv2. For example this is how it looks in other patches:
Index: code-editor-src/build/npm/dirs.js
===================================================================
--- code-editor-src.orig/build/npm/dirs.js
+++ code-editor-src/build/npm/dirs.js
| Index: code-editorv2/code-editor-src/src/vs/base/common/product.ts | ||
| =================================================================== | ||
| --- code-editorv2.orig/code-editor-src/src/vs/base/common/product.ts | ||
| +++ code-editorv2/code-editor-src/src/vs/base/common/product.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue here
Issue
D356975867
Enhanced the release workflow to support dual versioning by introducing a separate SageMaker Code Editor version alongside the Code Editor version. This allows independent version tracking for SageMaker-specific releases.
Description of Changes
Removed automatic tag-based triggers, now exclusively using workflow_dispatch with input of code-editor version and sagemaker-code-editor version
Added sagemakerCodeEditorVersion field alongside existing codeEditorVersion in product.json in compiled file
Testing
Tested locally by:
Creating tag 1.0.2 on branch 1.0
Running workflow with both version inputs: https://github.com/feiyangliu2023/code-editorv2/actions/runs/20097218364
Check artifact uploaded in local release: https://github.com/feiyangliu2023/code-editorv2/releases/tag/1.0.2
Extracting tarballs and verifying both version fields appear correctly in product.json
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.