Open
Conversation
|
I think it is very favorable that this approach clarifies the criteria for which PRs are subject to maintainer review. However, I believe most users, upon seeing that a PR has already been opened, would assume it will be merged in due course and would not think to react to the issue. For users who are unaware of this rule, we need to find a way to communicate that PRs will not be reviewed unless the corresponding issue receives reactions. |
There was a problem hiding this comment.
Does this mean that community reviews would essentially be phased out / no longer serve their role?
Comment on lines
+99
to
+100
| Pull requests will inherit the labels of the issue they address. Pull requests without a linked issue | ||
| are by default labeled `incubating`. We will have heavy-handed communication in the Contributing Guide |
There was a problem hiding this comment.
For PRs that are not linked to an issue, would they be promoted to accepting-prs if the PR itself receives more than 5 reactions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a request for comments about {RFC_DESCRIPTION}. See #877 for
additional details.
APIs are signed off by @mrgrain.
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache-2.0 license