Skip to content

fix(cli): on cdk import the option--role-arn is also parsed as --record-resource-mapping, creating a mapping file path from ARN #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhu85 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(cli): on cdk import the option--role-arn is also parsed as --record-resource-mapping, creating a mapping file path from ARN #1177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
255e639
fix(import): remove conflicting -r alias from --record-resource-mapping
abhu85 Feb 24, 2026
225804a
Merge branch 'main' into fix/import-r-alias-collision-1175
abhu85 Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/aws-cdk/lib/cli/cli-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,6 @@ export async function makeConfig(): Promise<CliConfig> {
},
'record-resource-mapping': {
type: 'string',
alias: 'r',
requiresArg: true,
desc: 'If specified, CDK will generate a mapping of existing physical resources to CDK resources to be imported as. The mapping ' +
'will be written in the given file path. No actual import operation will be performed',
Expand Down
1 change: 0 additions & 1 deletion packages/aws-cdk/lib/cli/cli-type-registry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,6 @@
},
"record-resource-mapping": {
"type": "string",
"alias": "r",
"requiresArg": true,
"desc": "If specified, CDK will generate a mapping of existing physical resources to CDK resources to be imported as. The mapping will be written in the given file path. No actual import operation will be performed"
},
Expand Down
1 change: 0 additions & 1 deletion packages/aws-cdk/lib/cli/parse-command-line-arguments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,7 +664,6 @@ export function parseCommandLineArguments(args: Array<string>): any {
.option('record-resource-mapping', {
default: undefined,
type: 'string',
alias: 'r',
requiresArg: true,
desc: 'If specified, CDK will generate a mapping of existing physical resources to CDK resources to be imported as. The mapping will be written in the given file path. No actual import operation will be performed',
})
Expand Down
Loading