agent/s3util: log to correct logger in headBucketTransport.RoundTrip#474
Open
chrisnovakovic wants to merge 1 commit intoaws:mainlinefrom
Open
agent/s3util: log to correct logger in headBucketTransport.RoundTrip#474chrisnovakovic wants to merge 1 commit intoaws:mainlinefrom
headBucketTransport.RoundTrip#474chrisnovakovic wants to merge 1 commit intoaws:mainlinefrom
Conversation
When the delegate responds with a status code indicating a redirect but no `Location` response header, the log message recording the status code override is sent to the package-wide mock logger defined in `test_s3util.go`, causing the message to be lost. Instead, send the message to the real logger referenced in the `headBucketTransport` struct. Fixes aws#473.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#473
Description of changes:
When the delegate responds with a status code indicating a redirect but no
Locationresponse header, the log message recording the status code override is sent to the package-wide mock logger defined intest_s3util.go, causing the message to be lost. Instead, send the message to the real logger referenced in theheadBucketTransportstruct.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.