Modernize build image and Python runtime#12
Open
cwaldbieser wants to merge 3 commits intoaws-samples:masterfrom
Open
Modernize build image and Python runtime#12cwaldbieser wants to merge 3 commits intoaws-samples:masterfrom
cwaldbieser wants to merge 3 commits intoaws-samples:masterfrom
Conversation
Lint & format.
Use modern Python and build image. Python 3.6 has been EOL for a while now. The latest Python runtime supported by Lambda is 3.9. The build image doesn't seem to be relatively modern, either. I just chose the latet Ubuntu LTS image from: https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-available.html That image should be good until 2027.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build image and Python runtime seem to be somewhat out of date. It would be great to see the upstream source incorporate these changes so deployers don't have to worry about out of date Lambda runtimes or EOL build images.
My linter also pointed out a few shell issues with quoting, long lines, and dead code. I made those changes as well.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.