feat: add --name support for gui-submit and improve parametrized job …#990
feat: add --name support for gui-submit and improve parametrized job …#990rickrams wants to merge 1 commit intoaws-deadline:mainlinefrom
Conversation
github-actions
bot
added
the
waiting-on-maintainers
rickrams
force-pushed
the
feat/gui-submit-name-and-parametrized-names
branch
from
35d19b4 to
19e7950
Compare
| submitter_name: str = field(default="JobBundle") | ||
|
|
||
| # Shared settings | ||
| name: str = field(default="Job bundle") |
There was a problem hiding this comment.
Need to check the code here, I see the JobBundleSettings class already has name as an attribute - and now we have a name_parameter so it maybe colliding in purpose / confusing to use in the near future.
There was a problem hiding this comment.
Need to pull it locally to double check how these work and / or conflict.
There was a problem hiding this comment.
Interesting, so the fork in code now takes the template name over the settings name
There was a problem hiding this comment.
yeah that was the original feature request. it's a less interesting feature request now that we have resubmit with edit. previously it was modifying a parameterized value with a fixed one which still seems 'wrong' if not that essential anymore.
rickrams
force-pushed
the
feat/gui-submit-name-and-parametrized-names
branch
2 times, most recently
from
1cf2ac1 to
8ee391e
Compare
…name handling This commit addresses two GitHub issues: Issue aws-deadline#859: Add --name support for gui-submit - Added --name option to 'deadline bundle gui-submit' command - Matches existing functionality in 'deadline bundle submit' Issue aws-deadline#460: Improved handling of parametrized job names - When template name is parametrized (e.g., name: '{{Param.JobName}}'): - The Name field on Shared job settings uses the parameter's default value - The JobName parameter is hidden from Job-specific settings tab - The name is passed as a parameter value instead of replacing the template - This preserves template portability and reusability Signed-off-by: rickrams <rickrams@users.noreply.github.com>
rickrams
force-pushed
the
feat/gui-submit-name-and-parametrized-names
branch
from
8ee391e to
2dcaa3f
Compare
|
|
The API change detection is flagging expected additions for this feature: JobBundleSettings.name_parameter - new attribute to track parametrized name source These are intentional additions, not breaking changes. The griffe breaking change check passes. |
2 participants
This commit addresses two GitHub issues:
Issue #859: Add --name support for gui-submit
Issue #460: Improved handling of parametrized job names
Fixes: #859 and #460
See DEVELOPMENT.md for information on running tests.
downloadorasset_syncmodules? NoWas this change documented?
Does this PR introduce new dependencies?
This library is designed to be integrated into third-party applications that have bespoke and customized deployment environments. Adding dependencies will increase the chance of library version conflicts and incompatabilities. Please evaluate the addition of new dependencies. See the Dependencies section of DEVELOPMENT.md for more details.
Is this a breaking change? No
Does this change impact security? No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.