Skip to content

feat: add deadline job download-input command#983

Draft
rickrams wants to merge 1 commit intoaws-deadline:mainlinefrom
rickrams:feat/job-download-input
Draft

feat: add deadline job download-input command#983
rickrams wants to merge 1 commit intoaws-deadline:mainlinefrom
rickrams:feat/job-download-input

Conversation

@rickrams
Copy link
Contributor

Add a new CLI command to download job input attachments, mirroring the existing download-output command.

What was the problem/requirement? (What/Why)

Occasionally it's useful to get the input assets from job attachments for a previously submitted job.

What was the solution? (How)

Creates a new download-input command mirroring the download-output command.

What is the impact of this change?

How was this change tested?

See DEVELOPMENT.md for information on running tests.

  • Have you run the unit tests? Yes!
  • Have you run the integration tests? YEs!
  • Have you made changes to the download or asset_sync modules? If so, then it is highly recommended
    that you ensure that the docker-based unit tests pass.

Was this change documented?

  • Are relevant docstrings in the code base updated? Yes
  • Has the README.md been updated? If you modified CLI arguments, for instance.

Does this PR introduce new dependencies?

This library is designed to be integrated into third-party applications that have bespoke and customized deployment environments. Adding dependencies will increase the chance of library version conflicts and incompatabilities. Please evaluate the addition of new dependencies. See the Dependencies section of DEVELOPMENT.md for more details.

  • This PR adds one or more new dependency Python packages. I acknowledge I have reviewed the considerations for adding dependencies in DEVELOPMENT.md.
  • This PR does not add any new dependencies.

Is this a breaking change?

A breaking change is one that modifies a public contract in a way that is not backwards compatible. See the
Public Contracts section
of the DEVELOPMENT.md for more information on the public contracts.

If so, then please describe the changes that users of this package must make to update their scripts, or Python applications.

Does this change impact security?

  • Does the change need to be threat modeled? For example, does it create or modify files/directories that must only be readable by the process owner?
    • If so, then please label this pull request with the "security" label. We'll work with you to analyze the threats.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions github-actions bot added the waiting-on-maintainers Waiting on the maintainers to review. label Jan 29, 2026
@rickrams rickrams force-pushed the feat/job-download-input branch 3 times, most recently from d7e7e23 to 67ff25a Compare January 29, 2026 17:31
@rickrams rickrams force-pushed the feat/job-download-input branch 9 times, most recently from adec40f to 8559088 Compare February 3, 2026 19:41
Add a new CLI command to download job input attachments, mirroring
the existing download-output command.

- Add _InputDownloader class to job_attachments/download.py (private API)
- Add download-input subcommand to deadline job CLI
- Fix get_job_input_paths_by_asset_root to use add_root_and_manifest_folder_prefix
  (matching asset_sync.py behavior)
- Fix test fixture inputManifestPath to match real API response format
- Add unit tests for download-input command and _InputDownloader class
- Handle cross-OS path prompts (same as download-output)

Signed-off-by: rickrams <rickrams@users.noreply.github.com>
@rickrams rickrams force-pushed the feat/job-download-input branch from 8559088 to 2e981ef Compare February 3, 2026 20:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
11.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-on-maintainers Waiting on the maintainers to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments