Skip to content

fix: heap overflow:CVE-2020-29596 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrlongsword wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: heap overflow:CVE-2020-29596 #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions http.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1266,7 +1266,12 @@ int _mwProcessReadSocket(HttpParam* hp, HttpSocket* phsSocket)
phsSocket->request.pucPayload = malloc(phsSocket->bufferSize);
phsSocket->pucData = phsSocket->request.pucPayload;
// payload length already received

// Fix heap overflow (CVE-2020-29596)
// We make sure that the length of phsSocket->dataLength doesn't exceed request.payloadSize
if (phsSocket->dataLength > phsSocket->request.payloadSize) phsSocket->dataLength = phsSocket->request.payloadSize;
phsSocket->dataLength -= phsSocket->request.headerSize;

// copy already received payload to payload buffer
memcpy(phsSocket->request.pucPayload, phsSocket->buffer + phsSocket->request.headerSize, phsSocket->dataLength);
phsSocket->request.pucPayload[phsSocket->dataLength]=0;
Expand Down