Merged
Conversation
Owner
|
Thanks for your work, I tried updating the offsets but without a console to actually test on I apparently got them wrong. |
Contributor
Author
|
Yes, I tested this on hardware! I verified the visitors and turnip prices, and both are displaying correctly with values that match. The weather seed also displays correctly. I confirmed this by restoring an old save and checking that it shows the same value, so the offset appears to be accurate. Let me know if you'd like me to test anything else specific! |
Owner
|
The weather seed offset matches what I had so it's probably correct. For some reason it looks like I messed up the turnip shop and visitor offsets. Thanks again for putting this together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the tool to work with version 3.0.0 by adding the new version enum and updating all parser offsets accordingly:
First off, thank you for creating and maintaining this amazing tool! It's been incredibly useful, and when the update to 3.0.0 came out, I genuinely missed being able to use it. The tool works so well that I couldn't go without it, so I took the time to update the offsets to make it compatible again
Looking forward to your feedback on these changes!
Closes #66