feat: flag to fail instead of skip if ./tests cases are missing
#253
+57
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARR4N
changed the title
./tests cases are missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
We weren't running execution spec tests for over a year because they are silently skipped if not present. They're introduced in #252 but it's not possible to guarantee that they're actually being run.
How this works
Introduces a flag to
./tests, which will cause a lack of spec-test directories or./testssubmodules to be fatal instead of silently skipped.How this was tested
Repeated CI runs on contiguous commits, the latter only adding the missing tests:
mainwith introduction of tests, no longer fails.