Skip to content

Conversation

@tstirrat15
Copy link
Contributor

Description

Part of preparing this repo for the use of release-please. We need to have conventional commits in place, so this adds a linter for that and does some other drive-by refactors to workflows.

Changes

  • Add conventional commit linting
  • Make the create-pull-request action tag with a conventional commit (feat to trigger a release)
  • Ensure that dependabot uses conventional commits
  • Some drive-by refactors

Testing

Review. See that tests pass.

@tstirrat15 tstirrat15 requested a review from a team as a code owner November 25, 2025 17:02
Comment on lines 12 to 26
name: "Lint"
runs-on: "depot-ubuntu-24.04-small"
steps:
- uses: "actions/checkout@v5"
- uses: "bahmutov/npm-install@v1"
- name: "Run prettier"
run: "CI=true yarn run prettier src -c"
- name: "Run lint"
run: "CI=true yarn lint"

conventional-commits:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI about 1 month ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

Comment on lines +23 to +32
name: "Lint Commit Messages"
runs-on: "depot-ubuntu-24.04-small"
if: "github.event_name == 'pull_request' && (github.event.action == 'opened' || github.event.action == 'synchronize' || github.event.action == 'reopened' || github.event.action == 'edited')"
steps:
- uses: "actions/checkout@v5"
- uses: "webiny/action-conventional-commits@v1.3.0"

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI about 1 month ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

@tstirrat15 tstirrat15 force-pushed the add-conventional-commit-linting branch from c09929b to fe9b601 Compare November 25, 2025 17:04
@tstirrat15 tstirrat15 force-pushed the add-conventional-commit-linting branch from fe9b601 to be0360a Compare November 25, 2025 17:08
@tstirrat15 tstirrat15 merged commit 7d022c4 into main Nov 30, 2025
10 checks passed
@tstirrat15 tstirrat15 deleted the add-conventional-commit-linting branch November 30, 2025 17:30
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants