Skip to content

Conversation

@tstirrat15
Copy link
Contributor

@tstirrat15 tstirrat15 commented Aug 27, 2025

Description

Since the last time authzed-java's API defs were updated, we added protovalidate to the definitions. This should make for a better experience validating protos in client code, but also requires additional proto to be brought in for the build step. You can see the errors that we hit here.

Changes

  • Bring in the missing proto by removing --exclude-imports and letting buf take care of things

Testing

Review

@tstirrat15 tstirrat15 requested a review from a team as a code owner August 27, 2025 21:27
@tstirrat15 tstirrat15 force-pushed the fix-protovalidate-dependencies branch from bac1fe5 to 015abc5 Compare August 27, 2025 21:31
@tstirrat15 tstirrat15 force-pushed the fix-protovalidate-dependencies branch from 015abc5 to a18b58d Compare August 27, 2025 21:37
@miparnisari miparnisari added this pull request to the merge queue Aug 27, 2025
Merged via the queue into main with commit af1e5e7 Aug 27, 2025
14 checks passed
@miparnisari miparnisari deleted the fix-protovalidate-dependencies branch August 27, 2025 22:02
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants