Migrate from NPM token to OIDC authentication (v4)#1250
Merged
developerkunal merged 3 commits intov4from Nov 19, 2025
Merged
Conversation
- Remove npm-token secret requirement from workflows - Add permissions block (contents: write, id-token: write) to release job - Remove NODE_AUTH_TOKEN environment variable from npm publish step - Set make_latest: false for GitHub releases to prevent v4 releases from being marked as latest - Update softprops/action-gh-release to v2.4.2 - Keep registry-url configuration for OIDC authentication
Contributor
Author
- Add v4 to pull_request and push branch triggers - Update cancel-in-progress to not cancel for both master and v4 branches
Contributor
|
Claude finished @developerkunal's task —— View job PR Review Progress
Overall Assessment❌ This PR has a critical configuration issue that will cause npm publish to fail. The workflow removes |
arpit-jn
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR migrates the npm publishing workflow from static token-based authentication to OIDC (OpenID Connect) authentication for the v4 branch.
What's changing:
npm-tokensecret requirement from all workflowspermissions: id-token: writeandcontents: writeto the release job innpm-release.ymlNODE_AUTH_TOKENenvironment variable from the npm publish stepmake_latest: falsein release-create action to prevent v4 releases from being marked as "latest"softprops/action-gh-releaseto v2.4.2 (pinned to commit hash)Why this is important:
Files changed:
.github/workflows/npm-release.yml- Added permissions, removed npm-token secret.github/workflows/release.yml- Removed npm-token from secrets.github/actions/npm-publish/action.yml- Removed npm-token input and NODE_AUTH_TOKEN env var.github/actions/release-create/action.yml- Added make_latest: false, updated to v2.4.2References
Testing
The trusted publishing configuration on npmjs.com should already be set up from PR #1249. The same OIDC setup works for both branches since they use the same workflow file (
release.yml) and environment (release).Testing approach:
Checklist