Feat: add constructor to set clientId on Client creation #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new constructor Client(String name, String clientId) to allow setting the immutable clientId field during object construction. The existing Client(String name) constructor remains unchanged to maintain backward compatibility. This allows users to optionally set the clientId at construction time when needed, while the field remains immutable (no setter exists). - Add Client(String name, String clientId) constructor with JavaDoc - Add test for backward compatibility (existing constructor) - Add test for new constructor functionality - All existing tests continue to pass
pmathew92
approved these changes
Oct 22, 2025
This was referenced Oct 23, 2025
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the changes made in #776