feat: add isTokenEndpointIpHeaderTrusted field to Client #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adenix
force-pushed
the
feature/client-is-token-endpoint-id-header-trusted
branch
3 times, most recently
from
d2113e9 to
cf51816
Compare
Add support for the is_token_endpoint_ip_header_trusted property in the Client class with proper JavaDoc documentation and test coverage. - Add isTokenEndpointIpHeaderTrusted field with @JsonProperty annotation - Add getter and setter methods with JavaDoc following class conventions - Update ClientTest with serialization and deserialization tests - Verify all tests pass successfully
adenix
force-pushed
the
feature/client-is-token-endpoint-id-header-trusted
branch
from
cf51816 to
a59a1c2
Compare
Contributor
Author
|
Adds support for #777 |
tanya732
reviewed
Oct 16, 2025
| * Whether the token endpoint IP header is trusted for this application. | ||
| * | ||
| * @return true if the token endpoint IP header is trusted, false otherwise. | ||
| */ |
Contributor
There was a problem hiding this comment.
Please add @JsonProperty("is_token_endpoint_ip_header_trusted"), to ensure consistent serialization/deserialization of the property
tanya732
reviewed
Oct 16, 2025
| * | ||
| * @param isTokenEndpointIpHeaderTrusted whether the token endpoint IP header is trusted or not. | ||
| */ | ||
| public void setIsTokenEndpointIpHeaderTrusted(Boolean isTokenEndpointIpHeaderTrusted) { |
Contributor
There was a problem hiding this comment.
Please add @JsonProperty("is_token_endpoint_ip_header_trusted") on setter, to ensure consistent serialization/deserialization of the property.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds support for the
is_token_endpoint_ip_header_trustedproperty to theClientclass in the Management API.Classes and methods added:
isTokenEndpointIpHeaderTrustedfield toClientclass with@JsonPropertyannotationgetIsTokenEndpointIpHeaderTrusted()getter method with JavaDocsetIsTokenEndpointIpHeaderTrusted(Boolean)setter method with JavaDocSummary of usage:
This property controls whether the token endpoint trusts IP headers for the application, which is relevant for scenarios where the application operates behind proxies or load balancers.
References
Testing
This change has been tested with comprehensive unit tests covering both serialization and deserialization:
ClientTest.shouldSerialize()to verify the field serializes correctly to JSONClientTest.shouldDeserialize()to verify the field deserializes correctly from JSON./gradlew test --tests ClientTestTest coverage includes:
truetrue@JsonPropertymapping to snake_case API field nameChecklist