Sf1 dm #288
Open
Sf1 dm #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aurelijusb
commented
Dec 3, 2019
| * @return Response | ||
| */ | ||
| public function index() | ||
| public function index(KernelInterface $request) |
Owner
Author
There was a problem hiding this comment.
👍 Šaunu, kad naudoji KernelInterface – tada ramiau galima judinti PHP failus tarp skirtingų katalogų
aurelijusb
commented
Dec 3, 2019
| {% for key, team in data %} | ||
| {% for student in team.students %} | ||
| <li class="list-group-item"> | ||
| <a href="{{ path('student', {name: student, project: key})|escape }}">{{ student }}</a> |
Owner
Author
There was a problem hiding this comment.
Symfony'je Twig'as standartinškai yra įjungęs autoescape
Suggested change
| <a href="{{ path('student', {name: student, project: key})|escape }}">{{ student }}</a> | |
| <a href="{{ path('student', {name: student, project: key}) }}">{{ student }}</a> |
aurelijusb
commented
Dec 3, 2019
| </ul> | ||
|
|
||
| <div class="m-4"> | ||
| <form action="/student" method="get"> |
Owner
Author
There was a problem hiding this comment.
Reikėtų įprasti visur naudoti path. Nes ateityje bus sunku visus hard-coded variantus sugaudyti
Owner
Author
|
Esmė gera, Pasitikrinimui yra testai: https://github.com/aurelijusb/kickstart/pull/288/files: |
Open
Owner
Author
|
Beje. Dėkui už tvarkingai atliktą darbą ir informavimą apie potencialias klaidas (51 studentą) |
Owner
Author
|
Pataisyta (ir įvertinta): https://github.com/dominykasmurauskas/kickstart/commit/0370998700cf96b460f1019cfb18814522ccb749 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased from #91
To include latest tests