Skip to content

Conversation

@indruteok
Copy link

No description provided.

aurelijusb and others added 11 commits November 10, 2019 18:34
So it would be clear, that all parts are working correctly,
leaving more time to Code review.

Adding screenshots and debugging intermediate results,
so it would be faster to evaluate and/or fix issues.

Using Cypress as one of Headless browser based test framework.
Cypress is running browser as a separate process,
so it was needed for custom debug function to see intermediate results
in GitHub actions as well.

Using e2e-tests.sh to reach docker network used by docker-compose.yml.

Initial idea was to use GitHub Checks Annotations,
but Cypress already formats output with colors.
So using just different indentation.

Video recording disabled to not abuse GitHub –
it already does tremendous job.

Using GitHub Action "if: always()" to store screenshots for both
successful builds and errors.

Documentation:
 * https://www.cypress.io/
 * cypress-io/cypress#3199
 * https://help.github.com/en/actions/automating-your-workflow-with-github-actions/development-tools-for-github-actions#set-a-warning-message-warning
 * https://help.github.com/en/actions/automating-your-workflow-with-github-actions/contexts-and-expression-syntax-for-github-actions#job-status-check-functions
Intention is to create similar project in symfony,
as is deployed on https://hw1.nfq2019.online

Note: https://hw1.nfq2019.online/students.json can be useful.
To cover other edge cases.
There was an error in https://hw1.nfq2019.online/
There should be 51 real students instead of 46 unique names.
@aurelijusb aurelijusb changed the base branch from master to homework-2019-11-14 December 14, 2019 14:50
@aurelijusb aurelijusb changed the title Symfony namu darbas 1 antra versija Symfony namu darbas 2 Dec 14, 2019
@aurelijusb
Copy link
Owner

aurelijusb commented Dec 14, 2019

Tikiuosi radau jau pakeitimus 🤞: #306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants