Open
Conversation
- deprecate TapeInfo.size and pos, replace with duration and position in milliseconds - add playbackRate (for potential future enhancement of accelerated tape loading) - add playbackRateChangeCallback to avoid client polling - remove myIsPlaying since it is redundant with myBaseCycles != -1 - update sdlsettings for new API
Owner
|
Do we really need the deprecation? Who is using it? |
Owner
|
|
Author
|
Re deprecation: I just wasn’t sure if any of your other frontends are using it. If it’s just sa2 then they can be deleted. Re |
Owner
|
OK, just remove the deprecated things. |
Author
|
@audetto removed the deprecated fields |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TapeInfo.sizeandpos, replace withdurationandpositionin millisecondsplaybackRate(for potential future enhancement of accelerated tape loading)playbackRateChangeCallbackto avoid client pollingmyIsPlayingsince it is redundant withmyBaseCycles!= -1notes:
sizeandposto avoid breaking any non-sa2 clientsFrameBasesee #338