-
Notifications
You must be signed in to change notification settings - Fork 2
Uv for benchmark compute5 #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideSwitches the benchmark environment to use uv with Python 3.12 and a pyproject-based dependency definition instead of manual virtualenv + requirements files, and adjusts system dependencies accordingly. Flow diagram for new benchmark environment setup with uvflowchart TD
A[install_dependencies.sh] --> B[Install system packages: sox, ffmpeg, libav*]
B --> C[Install system packages: libcairo2-dev, libmad0-dev, libgirepository1.0-dev]
C --> D[Install system package: gstreamer-1.0]
subgraph Previous_setup_removed
X1[Deactivate existing venv]
X2[Remove ENV_DIR]
X3[Create virtualenv with python3.10]
X4[Activate virtualenv]
X5[Upgrade pip]
X6[Purge pip cache]
X7[Install requirements from requirements.txt.lock]
end
A -.no longer executed .-> Previous_setup_removed
D --> E[Runtime uses uv and pyproject.toml for Python dependencies]
Flow diagram for running benchmarks with uv and Python 3.12flowchart TD
actor[Developer] --> R[run.sh]
R --> I[Initialize results directory]
I --> L[Loop over extensions exts]
L --> BR[uv run --python 3.12 benchmark_read.py --ext ext]
L --> BI[uv run --python 3.12 benchmark_info.py --ext ext]
BR --> UV1[uv resolves and installs dependencies from pyproject.toml]
BI --> UV2[uv reuses resolved environment]
UV1 --> P312[Python 3.12 runtime]
UV2 --> P312
P312 --> BR_DONE[Run benchmark_read.py]
P312 --> BI_DONE[Run benchmark_info.py]
L --> DONE[All extensions processed]
DONE --> PL[uv run --python 3.12 plot.py]
PL --> UV3[uv uses same environment]
UV3 --> P312
P312 --> PLOT_DONE[Generate benchmark plots]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Member
Author
|
Results are not different |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #175
Here we use
compute5to run the benchmarks.Summary by Sourcery
Switch benchmark scripts to use uv with Python 3.12 and update benchmark environment configuration.
Enhancements:
Build: