Skip to content

Add support for rock3b platform #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JDuchniewicz wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Add support for rock3b platform #552

JDuchniewicz wants to merge 17 commits into from

Conversation

@JDuchniewicz
Copy link

@JDuchniewicz JDuchniewicz commented Nov 12, 2025

No description provided.

@JDuchniewicz JDuchniewicz requested review from Ivan-Velickovic and removed request for Ivan-Velickovic November 12, 2025 06:42
omeh-a
omeh-a reviewed Nov 12, 2025
View reviewed changes
Copy link
Member

@omeh-a omeh-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just a few minor comments re: timer mostly.

@JDuchniewicz JDuchniewicz force-pushed the jakub/rock3b branch 2 times, most recently from 5881734 to 27bc016 Compare November 13, 2025 00:52
@JDuchniewicz
Copy link
Author

JDuchniewicz commented Nov 13, 2025

The builds will be failing until new version of sdf_gen is released because of adding a parameter to Serial class au-ts/microkit_sdf_gen#27

@JDuchniewicz
Copy link
Author

JDuchniewicz commented Nov 13, 2025 •
edited
Loading

Currently it is broken after 768 seconds due to an overflow in ticks calculation

midnightveil
midnightveil reviewed Nov 21, 2025
View reviewed changes
Copy link
Contributor

@midnightveil midnightveil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also add this to ci/matrix.py so that CI builds these examples.

@JDuchniewicz
Copy link
Author

JDuchniewicz commented Nov 23, 2025

Still waiting for a new release of https://github.com/au-ts/microkit_sdf_gen to happen before the CI will be passing. Are we okay with that @Ivan-Velickovic?

@Ivan-Velickovic
Copy link
Collaborator

Ivan-Velickovic commented Nov 24, 2025

Still waiting for a new release of https://github.com/au-ts/microkit_sdf_gen to happen before the CI will be passing. Are we okay with that @Ivan-Velickovic?

Need to merge some other things for sdfgen, will make a release by the end of the week hopefully.

@JDuchniewicz JDuchniewicz mentioned this pull request Dec 5, 2025
Open
JDuchniewicz and others added 17 commits December 9, 2025 11:35
@JDuchniewicz
dts: add rock3b.dts+init board support
c9d1caf 
Co-Authored-By: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
Signed-off-by: Szymon Duchniewicz <s.duchniewicz@unsw.edu.au>
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
@Willmish @JDuchniewicz
dts:rock3b: adjust memory region
6b39c61 
Co-Authored-By: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
Signed-off-by: Szymon Duchniewicz <s.duchniewicz@unsw.edu.au>
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
@JDuchniewicz
Working timer implemented using 2 peripherals.
0ec9fd4 
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
@JDuchniewicz
Add support for multiple channels
43fd29d 
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
@JDuchniewicz
Add support for serial
6042749 
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
@JDuchniewicz
add support for baud_rate in serial devices
844ff98 
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
@JDuchniewicz
WiP ethernet support for rock3b
45a5cb2 
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
@JDuchniewicz
Fix the timer driver
873076e 
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
@JDuchniewicz
Address review comments.
b7bc4ac 
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
@JDuchniewicz
Fix build errors
f68a6da 
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
@JDuchniewicz
Cleanup dts
7e12e3e 
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
@JDuchniewicz
Fix a bug in timeout setting
7511aa6 
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
@JDuchniewicz
Fix overflow in timer driver
35308af 
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
@JDuchniewicz
Fix uppercase naming of rk3568 platform
92ba6df 
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
@JDuchniewicz
Address review comments
1d3182c 
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
@JDuchniewicz
Fix formatting
fa21fc2 
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
@JDuchniewicz
Fix rebase errors
126c411 
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
@JDuchniewicz
Copy link
Author

JDuchniewicz commented Dec 9, 2025

@midnightveil this depends on seL4/microkit#356 so it won't build right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ivan-Velickovic Ivan-Velickovic Ivan-Velickovic left review comments

@omeh-a omeh-a omeh-a left review comments

@midnightveil midnightveil midnightveil left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JDuchniewicz @Ivan-Velickovic @omeh-a @midnightveil @Willmish