feat(crypto): Add robust debug mode and fix silent failure#21
Conversation
The crypto.sh module would previously fail silently if the `bitcoin-cli` command was not found, making it difficult to diagnose. This change introduces a robust, global debugging capability and ensures the script reports errors clearly. Key changes: - **`dashboard.sh`**: Exports the `DASHBOARD_DEBUG` variable and stops suppressing stderr from modules when in debug mode (`-v`). - **`modules/crypto.sh`**: - Integrates with the global `DASHBOARD_DEBUG` flag. - Enables `set -x` and detailed debug messages in `fetch_from_local_btc` when `DASHBOARD_DEBUG` is active. - Fixes the silent failure by checking the exit code of `fetch_from_local_btc` and exiting if it fails. - **`config/config.sh`**: Adds the configuration file, which was missing and required for the script to run.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR enhances the
crypto.shmodule by integrating it with the global debug system and fixing a silent failure. When the-vflag is used withdashboard.sh, the crypto module will now print detailed debug information. It also ensures that the script exits with an error if the local bitcoin provider fails, preventing silent errors.PR created automatically by Jules for task 12292379684621282419